Skip to content

8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows)#3983

Open
antonvoznia wants to merge 2 commits intoopenjdk:masterfrom
antonvoznia:JDK-8351359
Open

8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows)#3983
antonvoznia wants to merge 2 commits intoopenjdk:masterfrom
antonvoznia:JDK-8351359

Conversation

@antonvoznia
Copy link

@antonvoznia antonvoznia commented Sep 22, 2025

Hi,

It's a clean backport of JDK-8351359.
Changes are related to Windows only.

Testing:

  • manual testing code that calls getProcessCpuLoad() on windows server 2025, intel cpu
  • OpenJDK GHA Sanity Checks

Progress

  • Change must not contain extraneous whitespace
  • JDK-8351359 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows) (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3983/head:pull/3983
$ git checkout pull/3983

Update a local copy of the PR:
$ git checkout pull/3983
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3983

View PR using the GUI difftool:
$ git pr show -t 3983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3983.diff

Using Webrev

Link to Webrev Comment

…CpuLoad are stale after 24.8 days (Windows)

Reviewed-by: amenkov, sspitsyn
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 22, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

Hi @antonvoznia, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user antonvoznia" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@antonvoznia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 349 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 900b3ff7ee933520efe2438fb7c841a4e6a93d17 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows) Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 22, 2025
@antonvoznia
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 22, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2025

@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

⚠️ @antonvoznia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

@antonvoznia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@antonvoznia
Copy link
Author

/open

@openjdk openjdk bot reopened this Dec 20, 2025
@openjdk
Copy link

openjdk bot commented Dec 20, 2025

@antonvoznia This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2026

@antonvoznia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@pontusp
Copy link

pontusp commented Jan 30, 2026

@antonvoznia what happen to this pull request? Looking forward to getting this into JDK 17 // Regards pontusp (reporter of JDK-8351359)

@antonvoznia
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Feb 3, 2026

@antonvoznia The pull request is being re-evaluated and the inactivity timeout has been reset.

@antonvoznia
Copy link
Author

@pontusp ,
Hi, I’m waiting for maintainer approval.
The same fix was merged into JDK 21, so we’re ready to proceed with this one.

@jerboaa
Copy link
Contributor

jerboaa commented Feb 18, 2026

@antonvoznia You need to re-apply for approval. This is currently not showing up in the list of bugs to approve (missing approval label).

@antonvoznia antonvoznia changed the title 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows) Backport 900b3ff7ee933520efe2438fb7c841a4e6a93d17 Feb 19, 2026
@openjdk openjdk bot changed the title Backport 900b3ff7ee933520efe2438fb7c841a4e6a93d17 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows) Feb 19, 2026
@openjdk
Copy link

openjdk bot commented Feb 19, 2026

This backport pull request has now been updated with issue from the original commit.

@antonvoznia
Copy link
Author

/approval It's a clean backport to JDK17. The hanges are related to Windows only.

@openjdk
Copy link

openjdk bot commented Feb 19, 2026

@antonvoznia usage: /approval [<id>] (request|cancel) [<text>]

@antonvoznia
Copy link
Author

/approval request It's a clean backport to JDK17. The hanges are related to Windows only.

@openjdk
Copy link

openjdk bot commented Feb 19, 2026

@antonvoznia
8351359: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 19, 2026
@antonvoznia
Copy link
Author

@jerboaa , thank you, I've updated the label :)

@GoeLin
Copy link
Member

GoeLin commented Feb 20, 2026

HI @antonvoznia
you need to give a meaningful comment with your approval request, see also https://wiki.openjdk.org/spaces/JDKUpdates/pages/42598906/How+to+contribute+or+backport+a+fix
especially section 6.

You can issue the /approval command again with a approriate comment.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Feb 20, 2026
@antonvoznia
Copy link
Author

/approval request Fix request jdk17u-dev
Clean backport. Many machines are running over 24.8, they can encounter the issue.
I did manual testing of getProcessCpuLoad() call on windows server 2025, intel cpu, and GHA Sanity Checks, everything passed.
The risk is low.

@openjdk
Copy link

openjdk bot commented Feb 20, 2026

@antonvoznia
8351359: The approval request has been updated successfully.

@antonvoznia
Copy link
Author

@GoeLin , done.
Thanks!

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 20, 2026
@antonvoznia
Copy link
Author

Probably something wasn't stable in the test pipeline.
"Pre-submit tests - linux-x64 / build - Build / testFailing after 21m — 1/1 failed"

Because, before submitting this PR, I ran the tests in my fork, it was passed:
https://github.com/antonvoznia/jdk17u-dev/actions/runs/17910485691

@openjdk
Copy link

openjdk bot commented Feb 26, 2026

⚠️ @antonvoznia the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8351359
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

5 participants