You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This backport of JDK-8342934 fixes a bug in TypeMirror#toString output when printing types with multiple type annotations.
TypeMirror#toString is specified to return a string that is "suitable for representing this type in source code". This fix causes types with multiple annotations to be printed with a space separated list of annotations, instead of using ,, which would not be valid Java source. For example java.lang.@A @B String instead of java.lang.@A,@B String.
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
openjdkbot
changed the title
Backport ff165f9f0cf519144d7361b766bcce53d04c518e
8342934: TYPE_USE annotations printed with error causing "," in toString output
Jan 27, 2026
⚠️@cushon This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredrfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport of JDK-8342934 fixes a bug in
TypeMirror#toStringoutput when printing types with multiple type annotations.TypeMirror#toStringis specified to return a string that is "suitable for representing this type in source code". This fix causes types with multiple annotations to be printed with a space separated list of annotations, instead of using,, which would not be valid Java source. For examplejava.lang.@A @B Stringinstead ofjava.lang.@A,@B String.Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4243/head:pull/4243$ git checkout pull/4243Update a local copy of the PR:
$ git checkout pull/4243$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4243/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4243View PR using the GUI difftool:
$ git pr show -t 4243Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4243.diff
Using Webrev
Link to Webrev Comment