Skip to content

8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java#368

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8368181-V25
Open

8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java#368
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8368181-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Mar 10, 2026

Backporting JDK-8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java.

This PR adds java/awt/Dialog/ModalExcludedTest.java to the problem list.

For parity with Oracle JDK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8368181 needs maintainer approval

Issue

  • JDK-8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/368/head:pull/368
$ git checkout pull/368

Update a local copy of the PR:
$ git checkout pull/368
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/368/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 368

View PR using the GUI difftool:
$ git pr show -t 368

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/368.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 10, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7d3452b37eceff7309dc6b5285e3da31a3c398ec 8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java Mar 10, 2026
@openjdk
Copy link

openjdk bot commented Mar 10, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 10, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 11, 2026 13:32
@openjdk
Copy link

openjdk bot commented Mar 11, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2026
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Mar 11, 2026

/approval request for backport of JDK-8368181: ProblemList java/awt/Dialog/ModalExcludedTest/ModalExcludedTest.java.

This is a problem list update.

For parity with Oracle JDK.

@openjdk
Copy link

openjdk bot commented Mar 11, 2026

@rm-gh-8
8368181: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 11, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2026

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant