8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces#373
8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces#373rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces.
This PR cleans up trailing whitespace in x86-asmtest.py that was introduced in commit openjdk/jdk@916694f and went undetected because jcheck's [checks "whitespace"] config doesn't cover *.py files. The trailing whitespace causes pre-commit hooks to complain during merges, forcing developers to temporarily disable hooks as a workaround.
Ran related tests on linux-x64:
make test TEST="gtest:*AssemblerX86*"Results attached:
linux-x64-specific-test.log
Checked asmtest.out.h file created before and after the commit and they were identical:
asmtest.out.h.old.txt
asmtest.out.h.new.txt
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/373/head:pull/373$ git checkout pull/373Update a local copy of the PR:
$ git checkout pull/373$ git pull https://git.openjdk.org/jdk25u-dev.git pull/373/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 373View PR using the GUI difftool:
$ git pr show -t 373Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/373.diff
Using Webrev
Link to Webrev Comment