Skip to content

8357086: os::xxx functions returning memory size should return size_t#375

Open
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8357086
Open

8357086: os::xxx functions returning memory size should return size_t#375
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8357086

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 12, 2026

I backport this for parity with 21.0.11-oracle

Resolved two files, probably clean anyways:

src/hotspot/os/linux/os_linux.cpp
Resolve one chunk due to context. I omitted deleting an empty line that is not there in 25.

src/hotspot/share/runtime/os.hpp
Resolve one chunk due to context


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357086 needs maintainer approval

Issue

  • JDK-8357086: os::xxx functions returning memory size should return size_t (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/375/head:pull/375
$ git checkout pull/375

Update a local copy of the PR:
$ git checkout pull/375
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 375

View PR using the GUI difftool:
$ git pr show -t 375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/375.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport d5d94db12a6d82a6fe9da18b5f8ce3733a6ee7e7 8357086: os::xxx functions returning memory size should return size_t Mar 12, 2026
@openjdk
Copy link

openjdk bot commented Mar 12, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 12, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2026

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8357086 branch from d5cec37 to f4a610f Compare March 12, 2026 11:35
@openjdk
Copy link

openjdk bot commented Mar 12, 2026

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@reinrich
Copy link
Member

Hi Götz,
the test changes in test/hotspot/jtreg/compiler/... look like a mistake.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 13, 2026

HI @reinrich
thanks for pointing this out ... removed the edits to the test files.

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Cheers, Richard.

@openjdk
Copy link

openjdk bot commented Mar 13, 2026

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants