8357086: os::xxx functions returning memory size should return size_t#375
8357086: os::xxx functions returning memory size should return size_t#375GoeLin wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
d5cec37 to
f4a610f
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Hi Götz, |
|
HI @reinrich |
reinrich
left a comment
There was a problem hiding this comment.
Looks good.
Cheers, Richard.
|
|
I backport this for parity with 21.0.11-oracle
Resolved two files, probably clean anyways:
src/hotspot/os/linux/os_linux.cpp
Resolve one chunk due to context. I omitted deleting an empty line that is not there in 25.
src/hotspot/share/runtime/os.hpp
Resolve one chunk due to context
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/375/head:pull/375$ git checkout pull/375Update a local copy of the PR:
$ git checkout pull/375$ git pull https://git.openjdk.org/jdk25u-dev.git pull/375/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 375View PR using the GUI difftool:
$ git pr show -t 375Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/375.diff
Using Webrev
Link to Webrev Comment