Skip to content

8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores#377

Open
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8339526-c2-incorrect-clone
Open

8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores#377
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8339526-c2-incorrect-clone

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Mar 12, 2026

Fixes another C2 corner case.

Additional testing:

  • macos-aarch64-server-fastdebug, new test fails without the fix, passes with it
  • linux-aarch64-server-fastdebug, all

Progress

  • JDK-8339526 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/377/head:pull/377
$ git checkout pull/377

Update a local copy of the PR:
$ git checkout pull/377
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 377

View PR using the GUI difftool:
$ git pr show -t 377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/377.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2026

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5a2b0ca7fea7d1a283aa90696c3989ae189148ec 8339526: C2: store incorrectly removed for clone() transformed to series of loads/stores Mar 12, 2026
@openjdk
Copy link

openjdk bot commented Mar 12, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 12, 2026
@openjdk
Copy link

openjdk bot commented Mar 12, 2026

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2026

Webrevs

@shipilev
Copy link
Member Author

/approval request Fixes a C2 bug, regression in JDK 21, seen in the wild. Applies cleanly. New regression test fails without the fix, passes with it. All other testing passes as well. No bugtail since several months in mainline. Usual risk for C2 changes, but the fix also looks straightforward.

@openjdk
Copy link

openjdk bot commented Mar 12, 2026

@shipilev
8339526: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant