Skip to content

8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap#382

Open
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-9292244a-master
Open

8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap#382
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-9292244a-master

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 13, 2026

Hi all,

This pull request contains a backport of commit 9292244a from the openjdk/jdk26u repository.

The commit being backported was authored by Ramesh Bhagavatam Gangadhar on 13 Mar 2026 and had no reviewers.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8368524 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/382/head:pull/382
$ git checkout pull/382

Update a local copy of the PR:
$ git checkout pull/382
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 382

View PR using the GUI difftool:
$ git pr show -t 382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/382.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2026

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sendaoYan
Copy link
Member Author

Change has been verified locally on linux-x64 by run tests test/jdk/sun/security/pkcs11/Cipher/KeyWrap/NISTWrapKAT.java test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestGeneral.java test/jdk/sun/security/pkcs11/Cipher/KeyWrap/XMLEncKAT.java

@openjdk
Copy link

openjdk bot commented Mar 13, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test report skipped when could not find NSS. Change has been verified locally by run the releated tests. Test-fix only, no risk.

@openjdk openjdk bot changed the title Backport 9292244aef5b24d37105dbef9768db7ac423f366 8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap Mar 13, 2026
@openjdk
Copy link

openjdk bot commented Mar 13, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 13, 2026
@openjdk
Copy link

openjdk bot commented Mar 13, 2026

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2026
@openjdk
Copy link

openjdk bot commented Mar 13, 2026

@sendaoYan
8368524: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 13, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2026

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test report skipped when could not find NSS, parity with 25.0.4-oracle. Change has been verified locally by run the releated tests. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 13, 2026

@sendaoYan
8368524: The approval request has been updated successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant