Skip to content

8358600: Template-Framework Library: Template for TestFramework test class#384

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:pr/380from
rm-gh-8:JDK-8358600-V25
Open

8358600: Template-Framework Library: Template for TestFramework test class#384
rm-gh-8 wants to merge 1 commit intoopenjdk:pr/380from
rm-gh-8:JDK-8358600-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Mar 13, 2026

Backporting JDK-8358600: Template-Framework Library: Template for TestFramework test class.

This PR adds TestFrameworkClass to the template framework library. It is a reusable utility that generates the boilerplate class structure for IR Framework tests, so that template-based test generators only need to provide a list of @Test-annotated method tokens. This is foundational infrastructure for work generating IR/TestFramework tests.

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestWithTestFrameworkClass.java

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358600 needs maintainer approval

Integration blocker

 ⚠️ Dependency #380 must be integrated first

Issue

  • JDK-8358600: Template-Framework Library: Template for TestFramework test class (Sub-task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/384/head:pull/384
$ git checkout pull/384

Update a local copy of the PR:
$ git checkout pull/384
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 384

View PR using the GUI difftool:
$ git pr show -t 384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/384.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into pr/380 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b85fe02be5966b72ea1a92bfb3faf088d310219a 8358600: Template-Framework Library: Template for TestFramework test class Mar 13, 2026
@openjdk
Copy link

openjdk bot commented Mar 13, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 13, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 13, 2026 15:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Mar 13, 2026

/approval request for backport of JDK-8358600: Template-Framework Library: Template for TestFramework test class.

This is a test fix.

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

@openjdk
Copy link

openjdk bot commented Mar 13, 2026

@rm-gh-8
8358600: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant