8370489: Some compiler tests miss the @key randomness#389
Open
rm-gh-8 wants to merge 1 commit intoopenjdk:pr/388from
Open
8370489: Some compiler tests miss the @key randomness#389rm-gh-8 wants to merge 1 commit intoopenjdk:pr/388from
rm-gh-8 wants to merge 1 commit intoopenjdk:pr/388from
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Contributor
Author
|
Review will be requested after merging from head once the prerequisite is pushed. The merge from head will require a re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8370489: Some compiler tests miss the @key randomness.
This PR adds the missing @key randomness jtreg tag to compiler tests that use randomization via getRandomInstance() to properly categorize them for test execution filtering.
This PR is not clean because the following tests are currently not present in JDK 25
test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/loopopts/superword/TestAliasing.java
test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastIdentityTest.java
These tests were not included because it would involve backporting a fairly large commit dependency graph which includes behavioral changes (JDK-8361582, JDK-8324751 and JDK-8356760)
For parity with Oracle JDK.
It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:
8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST="test/hotspot/jtreg/compiler/arraycopy/stress test/hotspot/jtreg/compiler/intrinsics"
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/389/head:pull/389$ git checkout pull/389Update a local copy of the PR:
$ git checkout pull/389$ git pull https://git.openjdk.org/jdk25u-dev.git pull/389/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 389View PR using the GUI difftool:
$ git pr show -t 389Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/389.diff
Using Webrev
Link to Webrev Comment