Skip to content

8370489: Some compiler tests miss the @key randomness#389

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:pr/388from
rm-gh-8:JDK-8370489-V25-V2
Open

8370489: Some compiler tests miss the @key randomness#389
rm-gh-8 wants to merge 1 commit intoopenjdk:pr/388from
rm-gh-8:JDK-8370489-V25-V2

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Mar 13, 2026

Backporting JDK-8370489: Some compiler tests miss the @key randomness.

This PR adds the missing @key randomness jtreg tag to compiler tests that use randomization via getRandomInstance() to properly categorize them for test execution filtering.

This PR is not clean because the following tests are currently not present in JDK 25

test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/loopopts/superword/TestAliasing.java
test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastIdentityTest.java

These tests were not included because it would involve backporting a fairly large commit dependency graph which includes behavioral changes (JDK-8361582, JDK-8324751 and JDK-8356760)

For parity with Oracle JDK.

It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST="test/hotspot/jtreg/compiler/arraycopy/stress test/hotspot/jtreg/compiler/intrinsics"


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370489 needs maintainer approval

Integration blocker

 ⚠️ Dependency #388 must be integrated first

Issue

  • JDK-8370489: Some compiler tests miss the @key randomness (Bug - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/389/head:pull/389
$ git checkout pull/389

Update a local copy of the PR:
$ git checkout pull/389
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/389/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 389

View PR using the GUI difftool:
$ git pr show -t 389

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/389.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into pr/388 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4b774cb46d9355015a6bfcf53b47233d6f235239 8370489: Some compiler tests miss the @key randomness Mar 13, 2026
@openjdk
Copy link

openjdk bot commented Mar 13, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base approval Requires approval; will be removed when approval is received labels Mar 13, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 13, 2026 17:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Mar 13, 2026

Review will be requested after merging from head once the prerequisite is pushed. The merge from head will require a re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant