8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5#390
Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Open
8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5#390rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5.
This PR migrates the ThrowingPublishers test family (8 tests + abstract base) from TestNG to JUnit 5, converting data providers to @MethodSource, instance state to static, and the stop-after-first-failure mechanism to a JUnit TestWatcher/BeforeEachCallback extension..
For parity with Oracle JDK.
This PR is not clean because "test/jdk/java/net/httpclient/AbstractThrowingPublishers.java" skips a commit implementing JEP 517 (openjdk/jdk@e8db14f) which is not part of JDK 25. The file has been updated to preserve existing functionality while excluding the JEP 517 changes.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST="test/jdk/java/net/httpclient/ThrowingPublishersCustomAfterCancel.java test/jdk/java/net/httpclient/ThrowingPublishersCustomBeforeCancel.java test/jdk/java/net/httpclient/ThrowingPublishersIOAfterCancel.java test/jdk/java/net/httpclient/ThrowingPublishersIOBeforeCancel.java test/jdk/java/net/httpclient/ThrowingPublishersInNextRequest.java test/jdk/java/net/httpclient/ThrowingPublishersInRequest.java test/jdk/java/net/httpclient/ThrowingPublishersInSubscribe.java test/jdk/java/net/httpclient/ThrowingPublishersSanity.java"
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/390/head:pull/390$ git checkout pull/390Update a local copy of the PR:
$ git checkout pull/390$ git pull https://git.openjdk.org/jdk25u-dev.git pull/390/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 390View PR using the GUI difftool:
$ git pr show -t 390Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/390.diff
Using Webrev
Link to Webrev Comment