Skip to content

7904168: JMH: Fix integer overflow in samples#167

Closed
symious wants to merge 2 commits intoopenjdk:masterfrom
symious:FixtureOverflow
Closed

7904168: JMH: Fix integer overflow in samples#167
symious wants to merge 2 commits intoopenjdk:masterfrom
symious:FixtureOverflow

Conversation

@symious
Copy link
Copy Markdown
Contributor

@symious symious commented Jan 16, 2026 •
edited by openjdk Bot
Loading

This ticket is to fix the overflow issue of Integer, which is causing the measureRight benchmark to fail.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.org/jmh.git pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/167.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper Bot added the oca Needs verification of OCA signatory status label Jan 16, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Jan 16, 2026

Hi @symious, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user symious" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jan 16, 2026 •
edited
Loading

@symious This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904168: JMH: Fix integer overflow in samples

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@symious
Copy link
Copy Markdown
Contributor Author

symious commented Jan 20, 2026

/signed

@bridgekeeper bridgekeeper Bot added the oca-verify Needs verification of OCA signatory status label Jan 20, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Jan 20, 2026

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper Bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Feb 1, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 1, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Feb 1, 2026 •
edited
Loading

Webrevs

@symious
Copy link
Copy Markdown
Contributor Author

symious commented Feb 10, 2026

/touch

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 10, 2026

@symious The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 10, 2026

@symious This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev shipilev changed the title Fix overflow of integer 7904168: JMH: Fix integer overflow in samples Mar 19, 2026
shipilev
shipilev reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, a couple of nits.

Comment thread jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_05_StateFixtures.java Outdated
Copy link
Copy Markdown
Member

@shipilev shipilev Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to long here as well.

Comment thread jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_06_FixtureLevel.java Outdated
Copy link
Copy Markdown
Member

@shipilev shipilev Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, please change to long here.

@shipilev
Copy link
Copy Markdown
Member

shipilev commented Mar 19, 2026 •
edited
Loading

Also, please go to https://github.com/symious/jmh/actions and enable testing workflows. Then either trigger them manually, or do a commit that would trigger the run automatically.

@symious
Copy link
Copy Markdown
Contributor Author

symious commented Mar 20, 2026

@shipilev Thank you for the review. Updated, PTAL.

@shipilev
Copy link
Copy Markdown
Member

shipilev commented Mar 20, 2026

Merged GHA fix -- 5b34c95 -- please merge from master to get clean test run.

shipilev
shipilev reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks. Let's make sure GHA run is green, and then we can integrate.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

@symious Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

shipilev
shipilev approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks. Let's make sure GHA run is green, and then we can integrate.

@shipilev
Copy link
Copy Markdown
Member

shipilev commented Mar 20, 2026

Looks fine.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Mar 20, 2026
@shipilev
Copy link
Copy Markdown
Member

shipilev commented Mar 20, 2026

Say /integrate if you want to integrate.

@symious
Copy link
Copy Markdown
Contributor Author

symious commented Mar 20, 2026

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

@symious
Your change (at version c0b2b40) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Copy Markdown
Member

shipilev commented Mar 20, 2026

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

Going to push as commit 66b97c9.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 20, 2026
@openjdk openjdk Bot closed this Mar 20, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

@shipilev @symious Pushed as commit 66b97c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@symious
Copy link
Copy Markdown
Contributor Author

symious commented Mar 20, 2026

@shipilev Thank you for the review and sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shipilev shipilev shipilev approved these changes

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@symious @shipilev