Skip to content

7904155: SecurityManager tests fail with openjdk 25#169

Closed
vpa1977 wants to merge 6 commits intoopenjdk:masterfrom
vpa1977:CODETOOLS-7904155
Closed

7904155: SecurityManager tests fail with openjdk 25#169
vpa1977 wants to merge 6 commits intoopenjdk:masterfrom
vpa1977:CODETOOLS-7904155

Conversation

@vpa1977
Copy link
Copy Markdown
Contributor

@vpa1977 vpa1977 commented Feb 18, 2026

This PR disables Security Manager tests with OpenJDK 24 and up[1]. Alternative is disable it through the Maven profile.

Testing:

  • openjdk-25
mvn clean test
...
Failed tests: 
  CompilerControlDontInlineActualTest.testBenchmark:80 Failed with Throughput

Tests in error: 
  SafepointsProfilerTest.test:66 » IllegalState Cannot find the result for [safe...

Tests run: 72, Failures: 1, Errors: 1, Skipped: 18

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Java Microbenchmark Harness Parent 1.38-SNAPSHOT:
[INFO] 
[INFO] Java Microbenchmark Harness Parent ................. SUCCESS [  0.165 s]
[INFO] JMH Core ........................................... SUCCESS [  5.127 s]
[INFO] JMH Generators: Annotation Processors .............. SUCCESS [  0.352 s]
[INFO] JMH Core Integration Tests ......................... FAILURE [04:28 min]
[INFO] JMH Generators: Reflection ......................... SKIPPED
[INFO] JMH Generators: ASM ................................ SKIPPED
[INFO] JMH Core Compilation Tests ......................... SKIPPED
[INFO] JMH Core Benchmarks ................................ SKIPPED
[INFO] JMH Samples ........................................ SKIPPED
[INFO] JMH Generators: Bytecode ........................... SKIPPED
[INFO] JMH Archetypes ..................................... SKIPPED
[INFO] JMH Benchmark Archetype: Java ...................... SKIPPED
[INFO] JMH Benchmark Archetype: Scala ..................... SKIPPED
[INFO] JMH Benchmark Archetype: Groovy .................... SKIPPED
[INFO] JMH Benchmark Archetype: Kotlin .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  04:34 min
[INFO] Finished at: 2026-02-18T13:08:22+13:00

[1] https://openjdk.org/jeps/486


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/169/head:pull/169
$ git checkout pull/169

Update a local copy of the PR:
$ git checkout pull/169
$ git pull https://git.openjdk.org/jmh.git pull/169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 169

View PR using the GUI difftool:
$ git pr show -t 169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/169.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Feb 18, 2026

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 18, 2026

@vpa1977 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904155: SecurityManager tests fail with openjdk 25

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 991416d: 7904161: Add support for GC CPU time in GC profiler

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@vpa1977 vpa1977 marked this pull request as ready for review February 19, 2026 22:07
@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 19, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Feb 19, 2026

Webrevs

Copy link
Copy Markdown
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, thanks.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Mar 19, 2026
@vpa1977
Copy link
Copy Markdown
Contributor Author

vpa1977 commented Mar 19, 2026

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 19, 2026

@vpa1977 Only Committers are allowed to sponsor changes.

@shipilev
Copy link
Copy Markdown
Member

Say /integrate instead

@vpa1977
Copy link
Copy Markdown
Contributor Author

vpa1977 commented Mar 19, 2026

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 19, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 19, 2026

@vpa1977
Your change (at version c33447a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

Going to push as commit 5c9b628.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 991416d: 7904161: Add support for GC CPU time in GC profiler

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 20, 2026
@openjdk openjdk Bot closed this Mar 20, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

@shipilev @vpa1977 Pushed as commit 5c9b628.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vpa1977 vpa1977 deleted the CODETOOLS-7904155 branch March 20, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants