Skip to content

fix(features): disable CachePodLabelSelector and SandboxUpgradeResumeFromFailedStep by default#554

Open
zmberg wants to merge 1 commit into
openkruise:masterfrom
zmberg:modify-featuregates
Open

fix(features): disable CachePodLabelSelector and SandboxUpgradeResumeFromFailedStep by default#554
zmberg wants to merge 1 commit into
openkruise:masterfrom
zmberg:modify-featuregates

Conversation

@zmberg

@zmberg zmberg commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Disable CachePodLabelSelector feature gate by default (was enabled)
  • Disable SandboxUpgradeResumeFromFailedStep feature gate by default (was enabled)

These two features are not yet stable enough for default-on behavior and should require explicit opt-in.

…FromFailedStep by default

Signed-off-by: liheng <liheng.zms@alibaba-inc.com>
@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.66%. Comparing base (2b1118d) to head (122b109).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files         194      194           
  Lines       13774    13774           
=======================================
  Hits        10973    10973           
  Misses       2403     2403           
  Partials      398      398           
Flag Coverage Δ
unittests 79.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants