fix(updateops): handle deletion before mutual-exclusion check#564
fix(updateops): handle deletion before mutual-exclusion check#564zmberg wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 79.67% 79.67%
=======================================
Files 194 194
Lines 13784 13784
=======================================
Hits 10983 10983
Misses 2403 2403
Partials 398 398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9d3e72c to
a113b90
Compare
…d blocking finalizer removal Signed-off-by: liheng <liheng.zms@alibaba-inc.com>
a113b90 to
7da5de5
Compare
Summary
DeletionTimestampcheck before the mutual-exclusion check inSandboxUpdateOpsreconciler, so that a deleting ops is not blocked from finalizer removal by another active ops in the same namespace.SandboxUpdateOpswas inUpdatingphase, the controller would skip reconciliation entirely — including deletion handling. This caused finalizer removal to be delayed until the active ops completed (up to hours in production).Test plan
TestReconcile_DeletionNotBlockedByActiveOps: verifies deletion proceeds while another ops is Updating🤖 Generated with Claude Code