fix: handle edge cases in sandbox reuse lifecycle#569
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 79.78% 79.66% -0.13%
==========================================
Files 202 202
Lines 14688 14796 +108
==========================================
+ Hits 11719 11787 +68
- Misses 2544 2573 +29
- Partials 425 436 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zmberg
force-pushed
the
fix-reuse
branch
3 times, most recently
from
30a6eb3 to
ed4bb93
Compare
| return 0, fmt.Errorf("pod not found during reuse") | ||
| sbs, err := r.validateReusePreconditions(ctx, args) | ||
| if err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
if validation fail, shall we delete the sandbox directly ?
There was a problem hiding this comment.
yes, handleReuseFailed will handle that uniformly.
| return nil, fmt.Errorf("pod not found during reuse") | ||
| } | ||
|
|
||
| // If the Pod has already entered a terminal phase (Succeeded/Failed), the |
There was a problem hiding this comment.
shall we check the following condition
- whether sandbox is paused ?
- whether sandbox has pvc ?
Signed-off-by: liheng <liheng.zms@alibaba-inc.com>
3 participants
Summary
AnnotationReuseEnabledwhen clearing internal annotations in SandboxSetReuseCountprinter column to Sandbox CRDTest plan
🤖 Generated with Claude Code