fix: avoid misleading wait hook change logs#573
Conversation
Signed-off-by: Jayant <212013719+Jayant-kernel@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@AiRanthem review my pr |
|
@Jayant-kernel plz fix your UT |
|
Your unit tests are too messy. Please keep AI-generated code concise and high-quality. |
Signed-off-by: Jayant <212013719+Jayant-kernel@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 202 202
Lines 14688 14689 +1
=======================================
+ Hits 11719 11720 +1
Misses 2544 2544
Partials 425 425
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@AiRanthem |
Ⅰ. Describe what this PR does
This PR avoids a misleading debug log in the generic
WaitReconciler.Previously,
WaitReconciler.Reconcileloggedobject with wait hook changedfor every observed object update, even when no wait hook existed for that object. The log now happens only after the matching wait hook is found, immediately before the hook check runs.A regression test covers both cases:
object with wait hook changedlog is emitted;Ⅱ. Does this pull request fix one issue?
Fixes #571
Ⅲ. Describe how to verify it
The focused test is:
I could not run the Go test locally because the local Windows environment blocks the available Go binary from executing. The change is limited to the wait-hook log path and its regression test; GitHub CI should run the package tests.
Ⅳ. Special notes for reviews
No API, CRD, generated code, or behavior outside debug logging is changed.