Fix handling of custom MIMModule passed via createFederationExecution - #367
Open
JeanPhilippeLebel wants to merge 2 commits into
Open
Fix handling of custom MIMModule passed via createFederationExecution#367JeanPhilippeLebel wants to merge 2 commits into
JeanPhilippeLebel wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom MIM Module is provided via the createFederationExecution function, it gets added to the Fom Module list but during the actual federation creation, the standardMIM gets added as well leading to execution errors.
The provided fix explicitly defines the MIMModule as a separate variable and use it, or the default MIM, when required.
Right now, I think custom MIM Module handling is broken.
I think this should also be applied to the main branch.