You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Renames tally filter bin labels for partial currents belonging to structured meshes under a MeshSurfaceFilter. Previously, OpenMC would show 'x', 'y', and 'z' for all mesh types. Now, a CylindricalMesh will have 'r', 'phi', and 'z', and a SphericalMesh will have 'r', 'theta', and 'phi'. This is changed both in the statepoint file and in tallies.out.
The reason will be displayed to describe this comment to others. Learn more.
I'd like to review this before merging; will try to get to it today or tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging SoonPR will be merged in < 24 hrs if no further comments are made.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames tally filter bin labels for partial currents belonging to structured meshes under a
MeshSurfaceFilter. Previously, OpenMC would show 'x', 'y', and 'z' for all mesh types. Now, aCylindricalMeshwill have 'r', 'phi', and 'z', and aSphericalMeshwill have 'r', 'theta', and 'phi'. This is changed both in the statepoint file and in tallies.out.Fixes #4017
AI disclosure: Claude Opus 4.8 was used for initial implementation. Generated code was reviewed, revised, and tested by a human (me).
Checklist
I have made corresponding changes to the documentation (if applicable)