Open
Conversation
…abs() and may be caused by including jQuery library twice on the page. That's a guess.
… make this add on work in MT5.
byrnereese
pushed a commit
to byrnereese/mt-plugin-configassistant
that referenced
this pull request
Apr 29, 2011
…` masks earlier declaration in same scope at addons/ConfigAssistant.pack/lib/ConfigAssistant/Static.pm line 172.
Member
|
I know this pull request was issued a long time ago. I am sorry it has taken so long for us to take a look at including it. But in order for us to merge it in, we need you to update your branch using the latest from openmelody/mt-plugin-configassistant master. It appears that the branch above is based off of endevver's fork, which is no longer current. So we would like to merge this in, but need a little help from you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first time I've really used github, so forgive me if I'm out of place or, I'm doing this correctly.
Included in this pull request are changes you made in the endevver fork, and display changes that made the plugin appear to work better with MT. You obviously don't have to use those. I'm not sure how to exclude them from this request.
However, I think you should add to the documentation to say that StaticFilePath and StaticWebPath are needed for this plugin to work in MT5 (and maybe others). Without them, the plugin constructed URLs to some static content using the wrong path. I observed this behavior on the plugin settings page to the options.js file and a css file. Adding those two configuration directives fixed the error.