Skip to content

[ENH] Improve NotImplementedError Messages #1574

Merged
fkiraly merged 10 commits into
openml:mainfrom
EmanAbdelhaleem:enhance-NotImplementedError
Jan 14, 2026
Merged

[ENH] Improve NotImplementedError Messages #1574
fkiraly merged 10 commits into
openml:mainfrom
EmanAbdelhaleem:enhance-NotImplementedError

Conversation

@EmanAbdelhaleem

Copy link
Copy Markdown
Contributor

Metadata

@codecov-commenter

codecov-commenter commented Dec 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.78%. Comparing base (5d3cf0c) to head (8cae095).

Files with missing lines Patch % Lines
openml/runs/functions.py 33.33% 2 Missing ⚠️
openml/study/study.py 0.00% 2 Missing ⚠️
openml/tasks/functions.py 0.00% 2 Missing ⚠️
openml/tasks/task.py 0.00% 2 Missing ⚠️
openml/datasets/dataset.py 0.00% 1 Missing ⚠️
openml/runs/run.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1574   +/-   ##
=======================================
  Coverage   52.78%   52.78%           
=======================================
  Files          36       36           
  Lines        4331     4331           
=======================================
  Hits         2286     2286           
  Misses       2045     2045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is directly related to the code that was changed, so it may be newly introduced. Kindly check.

@geetu040 geetu040 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the error messages are descriptive enough.

Can you also update the error messages in study.py: "Tags for studies is not (yet) supported."

@geetu040 geetu040 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CC: @fkiraly @SimonBlanke for review/merge.

@fkiraly fkiraly merged commit 645ef01 into openml:main Jan 14, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Improve NotImplementedError Messages

4 participants