AUDIT-31: Fix null/empty/unreadable values in audit log field display#37
Open
shubhangiisinghh wants to merge 1 commit intoopenmrs:mainfrom
Open
AUDIT-31: Fix null/empty/unreadable values in audit log field display#37shubhangiisinghh wants to merge 1 commit intoopenmrs:mainfrom
shubhangiisinghh wants to merge 1 commit intoopenmrs:mainfrom
Conversation
Author
|
@ManojLL @wikumChamith Would be much grateful if you have a look at this when you get a chance !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUDIT-31: Fix null/empty/unreadable values in audit log field display
Problem
The audit log viewer was displaying raw "null" strings and blank values
for changed fields. This happened because:
Hibernate proxy loading which failed silently, showing nothing
with "Unable to read", losing valid data
Description of what I changed
instead of triggering Hibernate proxy errors that caused blank values
broken field doesn't wipe out the other
Issue I worked on
see https://openmrs.atlassian.net/browse/AUDIT-31
Checklist: I completed these to help reviewers :)