Skip to content

fix: add missing @param javadoc, null check, and remove leftover dev comments#40

Open
Muralikrishna23 wants to merge 2 commits intoopenmrs:mainfrom
Muralikrishna23:fix/code-quality-improvements
Open

fix: add missing @param javadoc, null check, and remove leftover dev comments#40
Muralikrishna23 wants to merge 2 commits intoopenmrs:mainfrom
Muralikrishna23:fix/code-quality-improvements

Conversation

@Muralikrishna23
Copy link
Copy Markdown

  1. AuditService.java

    • Added missing @param sortOrder in Javadoc for both getAllRevisions() overloads
  2. AuditServiceImpl.java

    • Added null check in mapAuditEntitiesToDetails() to prevent
      NullPointerException when null list is passed
  3. AuditlogwebController.java

    • Removed leftover inline dev comment "// <-- New param" from line 164

@Binayak490-cyber
Copy link
Copy Markdown

Hi @Muralikrishna23, have you gone through this before raising PR - https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants