AUDIT-26: Exclude abstract classes from audited entity validation#41
Open
shlok612 wants to merge 2 commits intoopenmrs:mainfrom
Open
AUDIT-26: Exclude abstract classes from audited entity validation#41shlok612 wants to merge 2 commits intoopenmrs:mainfrom
shlok612 wants to merge 2 commits intoopenmrs:mainfrom
Conversation
|
Could we add a test case that confirms abstract classes are filtered out ? |
Author
Thanks for the suggestion! I’ll add a unit test to verify that abstract classes are excluded from entity validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR fixes AUDIT-26 by excluding abstract and base classes from the audited entity validation logic.
❌ Problem
Abstract classes like BaseOpenmrsData and BaseOpenmrsMetadata were being included in the entity selection dropdown. These classes are not audited, leading to NotAuditedException at runtime.
✅ Solution
Added a filter to exclude abstract classes using Modifier.isAbstract() during validation.
🔍 Changes
📌 Impact