AUDIT-30: Fix changes not visible when filters applied in audit log view#42
Open
shubhangiisinghh wants to merge 1 commit intoopenmrs:mainfrom
Open
AUDIT-30: Fix changes not visible when filters applied in audit log view#42shubhangiisinghh wants to merge 1 commit intoopenmrs:mainfrom
shubhangiisinghh wants to merge 1 commit intoopenmrs:mainfrom
Conversation
|
I noticed this PR is linked to the AUDIT-30 Jira ticket. Just wanted to confirm if this change is part of that ticket’s scope. Also, I think there might already be a PR associated with it. Could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: AUDIT-30: Fix changes not visible when filters applied in audit log view
Description of what I changed
In
AuditLogViewService.fetchAuditLogsGlobal, the else branch was callinggetAllRevisionsAcrossEntitieswhich does not respect filters correctly.Replaced it with
getAllRevisionsAcrossEntitiesWithEntityType(passing nullfor entityType) so that username and date filters are properly applied.
Also fixed a redundant double userId resolution -the username string was
being passed into fetchAuditLogs and resolved to a userId a second time,
when it had already been resolved into filters.getUserId().
Issue I worked on
see https://openmrs.atlassian.net/browse/AUDIT-30
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request.