EVENT-51: Remove ActiveMQ/JMS and replace with in-memory Spring event dispatch#25
Open
wikumChamith wants to merge 3 commits intoopenmrs:masterfrom
Open
EVENT-51: Remove ActiveMQ/JMS and replace with in-memory Spring event dispatch#25wikumChamith wants to merge 3 commits intoopenmrs:masterfrom
wikumChamith wants to merge 3 commits intoopenmrs:masterfrom
Conversation
… dispatch Replaces the embedded ActiveMQ broker and JMS topic/subscriber machinery with a simple in-memory ConcurrentHashMap<String, Set<EventListener>> registry. Events are now dispatched synchronously via EventListener.onEvent(OpenMrsEntityEvent) instead of through JMS MapMessage. - Removes activemq-core and spring-jms dependencies - Deletes JmsEventPublisher; adds EventPublisher extending TransactionEventListener - Rewrites EventEngine as an in-memory pub/sub registry - Replaces EventListener extends javax.jms.MessageListener with EventListener.onEvent(OpenMrsEntityEvent) - Drops Destination-based API from Event facade (getDestination, getDestinationFor, shutdown)
Member
|
@wikumChamith did you ask claude to review this? |
Member
|
I was going to comment on this, but my question is: if we move everything to Spring Application Events, do we even need something that listeners register with, etc.? I.e., don't we just get that for free? |
… dispatch Replaces the embedded ActiveMQ broker and JMS topic/subscriber machinery with a simple in-memory ConcurrentHashMap<String, Set<EventListener>> registry. Events are now dispatched synchronously via EventListener.onEvent(OpenMrsEntityEvent) instead of through JMS MapMessage. - Removes activemq-core and spring-jms dependencies - Deletes JmsEventPublisher; adds EventPublisher extending TransactionEventListener - Rewrites EventEngine as an in-memory pub/sub registry - Replaces EventListener extends javax.jms.MessageListener with EventListener.onEvent(OpenMrsEntityEvent) - Drops Destination-based API from Event facade (getDestination, getDestinationFor, shutdown)
… dispatch Replaces the embedded ActiveMQ broker and JMS topic/subscriber machinery with a simple in-memory ConcurrentHashMap<String, Set<EventListener>> registry. Events are now dispatched synchronously via EventListener.onEvent(OpenMrsEntityEvent) instead of through JMS MapMessage. - Removes activemq-core and spring-jms dependencies - Deletes JmsEventPublisher; adds EventPublisher extending TransactionEventListener - Rewrites EventEngine as an in-memory pub/sub registry - Replaces EventListener extends javax.jms.MessageListener with EventListener.onEvent(OpenMrsEntityEvent) - Drops Destination-based API from Event facade (getDestination, getDestinationFor, shutdown)
Member
Author
Good call. I tried to follow the structure in the old one looks like we don't need it. I updated the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the embedded ActiveMQ broker and JMS topic/subscriber machinery with a simple in-memory ConcurrentHashMap<String, Set> registry. Events are now dispatched synchronously via EventListener.onEvent(OpenMrsEntityEvent) instead of through JMS MapMessage.
Tlcket: https://openmrs.atlassian.net/browse/EVNT-51