SXS-37: Replace net.sf.cglib with org.springframework.cglib#17
SXS-37: Replace net.sf.cglib with org.springframework.cglib#17dkayiwa merged 1 commit intoopenmrs:masterfrom
Conversation
|
Shouldn't this pull request also contain the fix for? https://pastebin.com/ky1BTRGQ |
I don't think it is related to this. Is it ok if we fix it in a separate PR? |
| import com.thoughtworks.xstream.io.HierarchicalStreamWriter; | ||
| import com.thoughtworks.xstream.mapper.CGLIBMapper; | ||
| import com.thoughtworks.xstream.mapper.Mapper; | ||
| import org.springframework.cglib.proxy.Enhancer; |
There was a problem hiding this comment.
Shouldn't this import be ordered with the other org imports?
There was a problem hiding this comment.
@ibacher, I updated the PR according to this. However, few places in our code base do not follow this:
There was a problem hiding this comment.
We should eventually fix those. Technically the import order is part of our coding standards, but it's not well-enforced across projects.
This PR fixes that issue: openmrs/openmrs-module-referencemetadata#70 |
Ticket: https://openmrs.atlassian.net/browse/SXS-37