[label projection] scVI+scArches+XGBoost#853
Merged
scottgigante-immunai merged 18 commits intoopenproblems-bio:mainfrom Mar 15, 2023
Merged
[label projection] scVI+scArches+XGBoost#853scottgigante-immunai merged 18 commits intoopenproblems-bio:mainfrom
scottgigante-immunai merged 18 commits intoopenproblems-bio:mainfrom
Conversation
…roblems into scvi-scarches-xgb
…scvi-scarches-xgb
… into scvi-scarches-xgb
…Problems into scvi-scarches-xgb
Contributor
Collaborator
Author
LuckyMD
approved these changes
Mar 15, 2023
Collaborator
LuckyMD
left a comment
There was a problem hiding this comment.
This looks good to me. I don't recall all of the xgboost hyperparameters I initially selected, but this looks similar to what i would have gone for ^^. Thanks so much for doing this!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 95.60% 95.48% -0.12%
==========================================
Files 187 188 +1
Lines 4980 5055 +75
Branches 273 279 +6
==========================================
+ Hits 4761 4827 +66
- Misses 141 148 +7
- Partials 78 80 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Collaborator
|
Thank you, Scott! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission type
Testing
request (include link to passed test on NF Tower found in GitHub Actions summary: )
Submission guidelines
Contributing document
same update/change (closes Scvi scarches xgb #494)
PR review checklist
This PR will be evaluated on the basis of the following checks: