Skip to content

Incr method#11

Open
splitice wants to merge 6 commits into
openresty:masterfrom
splitice:master
Open

Incr method#11
splitice wants to merge 6 commits into
openresty:masterfrom
splitice:master

Conversation

@splitice

Copy link
Copy Markdown

Incrementing by value, defaults to 1. Happy to do the documentation if you do the tests :)

@agentzh

agentzh commented Nov 25, 2015

Copy link
Copy Markdown
Member

@splitice I can do the documentation if you do the tests ;)

@splitice

Copy link
Copy Markdown
Author

Haha, I would rather this not be the same as the incr method pull request from a year ago for the ngx-lua-module that's still pending due to me not having time to learn the test format and set up an environment for it.

@agentzh

agentzh commented Nov 25, 2015

Copy link
Copy Markdown
Member

@splitice Heh, sorry about your pending PRs. Bug fixes usually take much higher priority than new features. But don't worry, I'll eventually clean up the pending PR list when I have a chance :) To assure you, those PRs are never forgotten.

@splitice

Copy link
Copy Markdown
Author

No need to worry, its not really a concern for me since we build our own repo anyway, just trying to open source what we can.

This one here should be pretty easy 👍

I may also do flush_all from the TODO list in the future, I suspect we will need it down the line.

@agentzh

agentzh commented Nov 25, 2015

Copy link
Copy Markdown
Member

@splitice Awesome! Thank you a lot for your contribution!

@agentzh

agentzh commented Nov 25, 2015

Copy link
Copy Markdown
Member

@splitice BTW, I'll write up some tutorials on the test toolchain used here soon :)

@splitice

Copy link
Copy Markdown
Author

That would be great. I am in openresty-en so I'll keep an eye out. :)

@i19

i19 commented May 30, 2016

Copy link
Copy Markdown

+1

@splitice

splitice commented Jun 2, 2016

Copy link
Copy Markdown
Author

Incr now respects expiration time.
Get now checks expiration time before LRU
Added basic cleanup method to walk the last N nodes (LRU order) and clear if expired

@agentzh

agentzh commented Jun 2, 2016

Copy link
Copy Markdown
Member

@splitice See https://openresty.gitbooks.io/programming-openresty/content/testing/index.html for the tutorial on the test toolchain. Let me know if there's anything missing.

@splitice

splitice commented Jun 5, 2016

Copy link
Copy Markdown
Author

Sorry I dont currently have time to undertake that. Just moving some of the patches made in our private repo into the public forks.

Anyone: feel free to undertake the test building. Submit a PR to my fork and I'll happily accept to forward onto this PR.

@Triple-Z

Copy link
Copy Markdown

any update on this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants