Skip to content

NoWhitespaceBefore breaking format forLoopWithCorrectSpacing #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pankraz76 wants to merge 1 commit into from
Closed

NoWhitespaceBefore breaking format forLoopWithCorrectSpacing #6084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions rewrite-java-test/src/test/java/org/openrewrite/java/format/NoWhitespaceBeforeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,4 +765,67 @@ private static Consumer<SourceSpec<J.CompilationUnit>> autoFormatIsIdempotent()
return spec -> spec.afterRecipe(cu ->
Assertions.assertThat(new AutoFormatVisitor<>().visit(cu, 0)).isEqualTo(cu));
}

@Test
void forLoopWithCorrectSpacing() {
Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not reproduceable yet.

rewriteRun(
spec -> spec.parser(JavaParser.fromJavaVersion().styles(noWhitespaceBeforeStyle())),
java(
"""
class Test {
public static void main(String[] args) {
for (int i = 0; i < args.length; i++) {
System.out.println(args[i]);
}
}
public static void main2(String[] args) {
for (final String arg : args) {
System.out.println(arg);
}
}
public int indexOfFirstValue(final Object[] multipleValues) {
for (int i = 0; i < multipleValues.length; i++) {
if (multipleValues[i] != null) {
return i;
}
}
for (int i = 0; i < multipleValues.length; i++) { // space
if (multipleValues[i] != null) {
return i;
}
}
return -1;
}
}
""",
"""
class Test {
public static void main(String[] args) {
for (int i = 0; i < args.length; i++) {
System.out.println(args[i]);
}
}
public static void main2(String[] args) {
for (final String arg : args) {
System.out.println(arg);
}
}
public int indexOfFirstValue(final Object[] multipleValues) {
for (int i = 0; i < multipleValues.length; i++) {
if (multipleValues[i] != null) {
return i;
}
}
for (int i = 0; i < multipleValues.length; i++) { // space
if (multipleValues[i] != null) {
return i;
}
}
return -1;
}
}
"""
)
);
}
}