Fix InMemoryDataTableStore.getRows returning only first matching bucket#7276
Closed
jkschneider wants to merge 1 commit intomainfrom
Closed
Fix InMemoryDataTableStore.getRows returning only first matching bucket#7276jkschneider wants to merge 1 commit intomainfrom
jkschneider wants to merge 1 commit intomainfrom
Conversation
getRows returned early on the first (name, group) match instead of concatenating rows from all matching buckets. This caused ungrouped tables with different instance names to lose rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemoryDataTableStore.getRowsreturned early on the first(name, group)match instead of iterating all buckets and concatenating rows. When multiple ungrouped tables with different instance names contributed rows, only the first bucket's rows were returned.getRowsAggregatesAcrossUngroupedBuckets) that inserts rows into two ungrouped tables with different instance names and assertsgetRowsreturns rows from both. This test fails against the old code and passes with the fix.Test plan
getRowsAggregatesAcrossUngroupedBucketsverified to fail before fix and pass afterDataTableStoreTesttests continue to pass