Skip to content

When the CachingMavenRecipeBundleResolver is closed, ensure that all cached MavenRecipeBundleResolver instances are closed as well#7277

Merged
shanman190 merged 1 commit intomainfrom
bugfix/file-resource-leak
Apr 3, 2026
Merged

When the CachingMavenRecipeBundleResolver is closed, ensure that all cached MavenRecipeBundleResolver instances are closed as well#7277
shanman190 merged 1 commit intomainfrom
bugfix/file-resource-leak

Conversation

@shanman190
Copy link
Copy Markdown
Contributor

What's changed?

  • When the CachingMavenRecipeBundleResolver is closed, it now forces the closing of all cached MavenRecipeBundleResolver instances.
  • Add cached resolver connection leak detection
  • Rethrow first exception when closing all cached resolvers

What's your motivation?

We observed file handle leaks on Windows that were later throwing exceptions in CI tests.

Anything in particular you'd like reviewers to focus on?

N/A

Anyone you would like to review specifically?

N/A

Have you considered any alternatives or workarounds?

N/A

Any additional context

N/A

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…l cached `MavenRecipeBundleResolver` instances are closed as well
@shanman190 shanman190 self-assigned this Apr 3, 2026
@shanman190 shanman190 added the bug Something isn't working label Apr 3, 2026
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 3, 2026
@shanman190 shanman190 merged commit 3ff022e into main Apr 3, 2026
1 check passed
@shanman190 shanman190 deleted the bugfix/file-resource-leak branch April 3, 2026 23:41
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant