Add getAllRows() to DataTableStore for cross-bucket aggregation#7278
Closed
Add getAllRows() to DataTableStore for cross-bucket aggregation#7278
Conversation
InMemoryDataTableStore.getRows(name, group) only returns rows from the first matching bucket. When multiple sub-recipes in a composite recipe (like DevCenter) create separate DataTable instances with the same class name but different instance names, each gets its own bucket. getRows() finds only the first one, silently dropping rows from the others. This causes non-deterministic data loss because ConcurrentHashMap iteration order determines which bucket is found first. Add DataTableStore.getAllRows(name) that aggregates rows across all buckets with a given data table name, regardless of group or instance name. InMemoryDataTableStore overrides it to scan all buckets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemoryDataTableStore.getRows(name, group)only returns rows from the first matching bucket when group is nullgetRows()finds only the first one, silently dropping rows from the others -- causing non-deterministic data loss on SaaS V1DataTableStore.getAllRows(name)that aggregates rows across all buckets with a given data table nameTest plan