Fix CsvDataTableStore.getRows() returning String[] where other implementation returned typed objects#7279
Merged
jkschneider merged 2 commits intomainfrom Apr 4, 2026
Merged
Conversation
jkschneider
approved these changes
Apr 4, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So for example the GenerateCalmArchitechture prethink recipe running in a unit test would call
InMemoryDataTableStore.getRows()and get back aServiceEndpoints.Rowand pass.When the same recipe ran via the CLI it would call
CsvDataTableStore.getRows()and get back aString[]and fail because it did not expect that.Initially the
SourcesFileErrorsdata table didn't report these failures either because they happened in the second cycle and were omitted due toDataTable.allowWritingInthisCycle()returningfalse. This led to the frustrating situation where recipe errors would be reported in the console but there would be no data table to look at to find out what the errors actually were.