Conversation
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jul 9, 2025
Summary: this buckifies relaxed_ik, our highly modified third-party inverse kinematics solver while introducing the least amount of third party libraries also switches `k` to a fork that uses `nalgebra=0.33` (trivial fix), submitted a PR to the original repo openrr/k#153 Reviewed By: forrestsmithfb Differential Revision: D77805949 Privacy Context Container: L1133034 fbshipit-source-id: e48663e588e48cfdc72a94ddbbbba3aed2274800
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jul 9, 2025
Summary: this buckifies relaxed_ik, our highly modified third-party inverse kinematics solver while introducing the least amount of third party libraries also switches `k` to a fork that uses `nalgebra=0.33` (trivial fix), submitted a PR to the original repo openrr/k#153 Reviewed By: forrestsmithfb Differential Revision: D77805949 Privacy Context Container: L1133034 fbshipit-source-id: e48663e588e48cfdc72a94ddbbbba3aed2274800
Contributor
|
Thanks for the PR! As said in #66 (comment), we are using k in openrr/urdf-viz which depends on kiss3d, so compatibiliy with kiss3d is a bit important than "just examples". That said, I think we can accept this PR if this PR's approach would work in urdf-viz too. |
Contributor
|
Considering the new kiss3d version with the latest nalgebra, this can now be made even simplar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated all the dependencies to their latest versions.
I had to add a bit of a hack to fix the dependency issue for
nalgebrain the examples (kiss3dis using an older version). Hopefully its fine because they're just examples.All tests passed.