Refactor tempfile creation (SOFTWARE-5531)#171
Draft
brianhlin wants to merge 3 commits into
Draft
Conversation
brianhlin
force-pushed
the
SOFTWARE-5531.refactor-tempfile-creation
branch
from
092c982 to
a8d2271
Compare
brianhlin
force-pushed
the
SOFTWARE-5531.refactor-tempfile-creation
branch
from
a8d2271 to
948ac52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
GenerateFilenameto use thetempfilelibrary, making it return a_TemporaryFileWrapper(file-like interface), and fixes theprefixarg to work as documented (i.e., callers don't need to add the trailing.)Marked as WIP because 1) the tar bits are unfinished, 2) needs some actual testing, and 3) would be nice to finally add some type hints.