Add Unit Test for CompressOutbox to Tempfile Creation Refactoring (SOFTWARE-5540)#176
Open
jeff-takaki wants to merge 10 commits into
Open
Conversation
brianhlin
changed the title
Member
|
@jtakaki-matc I don't see anything obvious that would indicate why this failed so I would
|
jeff-takaki
force-pushed
the
SOFTWARE-5540-unittest-compress-outbox-1
branch
from
763a4ff to
46d3c94
Compare
Contributor
Author
|
@brianhlin Test seems to be working, checked locally running from 2.x branch as well. |
brianhlin
requested changes
Aug 1, 2023
jeff-takaki
changed the title
Co-authored-by: Brian Lin <brianhlin@gmail.com>
Contributor
Author
|
@brianhlin Added two more tests! |
brianhlin
requested changes
Aug 8, 2023
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
A couple of improvements to be made but this is looking great!
| names.sort() | ||
| outfiles.sort() | ||
|
|
||
| self.assertListEqual(names, outfiles) |
Member
There was a problem hiding this comment.
This is a good assertion! Another one would be to also check that the contents are expected
Co-authored-by: Brian Lin <brianhlin@gmail.com>
Make corrections to tarball file extraction and tarball location check
Contributor
Author
|
@brianhlin Made a few changes per your suggestions. |
brianhlin
approved these changes
Aug 15, 2023
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
Looks solid! A suggestion to improve the message upon one test failure and a slight logic issue. Pre-approving
Co-authored-by: Brian Lin <brianhlin@gmail.com>
brianhlin
reviewed
Aug 16, 2023
get_tarball_function handles IndexError exception and fails test if no tarball is created. test_tarball_creation and test_tarball_contents both make a call to this function
Contributor
Author
|
@brianhlin Refactored! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brianhlin I have been getting
AssertionError: False is not trueand I think it has to do with how I am using the mock patch. I tried a few different ways of incorporating the mock with not much success. It's possible I am provisioning the test environment incorrectly??