Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #40 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 7 7
Lines 109 109
Branches 25 25
=======================================
Hits 106 106
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you the changes were made. |
|
Hi @sadrasabouri , I hope you're doing well |
Hey, thanks for checking. I just checked now and I have access. I will review in coming days. |
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
Well done. I left some minor comments.
rokh/events/jalali.py
Outdated
| {'description': 'روز نیروی انتظامی', 'is_holiday': False}], | ||
| '14': [{'description': 'روز دامپزشکی', 'is_holiday': False}], | ||
| '15': [{'description': 'روز روستا و عشایر', 'is_holiday': False}, | ||
| {'description': 'روز جهانی حماسه فلسطین', 'is_holiday': False}], |
There was a problem hiding this comment.
I checked it in Bahesab Calendar and in 1403 and 1404 it was both on October 7th
Are you sure about Nov 29th
There was a problem hiding this comment.
I guess you're right. The one I looked at was روز جهانی همبستگی با مردم فلسطین, which is different.
…it to the gregorian calendar
I will complete my review within the next 24 hours ⌚ |
| {'description': 'برگزاری انتخابات دوره نخست مجلس شورای ملی', 'is_holiday': False}, | ||
| {'description': 'روز کفاش، صنعت کفش و چرم', 'is_holiday': False}, | ||
| {'description': 'روز خرما', 'is_holiday': False}], | ||
| '26': [{'description': 'لغو عهدنامه ۱۹۷۵ الجزایر توسط صدام حسین', 'is_holiday': False}, |
There was a problem hiding this comment.
روز اورژانس و فوریت های پزشکی
| }, | ||
| # مهر | ||
| "7": { | ||
| '1': [{'description': 'زادروز محمدرضا شجریان خواننده، موسیقیدان و خوشنویس ایرانی', 'is_holiday': False}, |
4 participants
In this PR i added the events of second four months Mordad, Shahrivar, Mehr and Aban events from the Bahesab Calendar
here are couple of questions about this PR:
1-August 1st -> "روز جهانی شیر مادر" and "آغار هفته جهانی شیردهی" is both of these events needed?
2-According to Bahesab calendar "روز جهانی دریانوردی" is on September 30th but according to our last resource it was mentioned on the September 25th and based on my research that's the correct date should we mention it on 30th too?
3-According to Bahesab calendar "روز جهانی کودک " is on October 8th but according to our last resource it was mentioned on the November 20th and based on my research that's the correct date should we mention it on 8th too?