ShardFailure response must not require the 'primary' property#1878
Open
janhoy wants to merge 1 commit intoopensearch-project:mainfrom
Open
ShardFailure response must not require the 'primary' property#1878janhoy wants to merge 1 commit intoopensearch-project:mainfrom
janhoy wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
janhoy
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
janhoy
commented
Feb 13, 2026
java-codegen/src/main/java/org/opensearch/client/codegen/transformer/overrides/Overrides.java
Outdated
Show resolved
Hide resolved
janhoy
commented
Feb 13, 2026
Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
janhoy
force-pushed
the
reproduce-shard_failure_parsing
branch
from
526be73 to
04c58f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a request returns error with
failed_shards, the current json parsing code requires that the shard object has aprimaryboolean property, but that is not always the case. The requirement was introduced in opensearch-project/opensearch-api-specification#981. This PR is only to add a failing unit test, that should be resolved once opensearch-project/opensearch-api-specification#1039 is merged and released.Issues Resolved
This PR does not resolve anything, only adds a test, see above.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.