[1887] Fix NPE in transport option conversion#1888
Open
baekgyu-kim wants to merge 1 commit intoopensearch-project:mainfrom
Open
[1887] Fix NPE in transport option conversion#1888baekgyu-kim wants to merge 1 commit intoopensearch-project:mainfrom
baekgyu-kim wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
baekgyu-kim
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
Signed-off-by: Baekgyu <baekgyukim.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change prevents NullPointerException in transport option conversion.
ApacheHttpClient5Options.of(...) and RestClientOptions.of(...) now safely handle null input options, headers(), and queryParameters() (treated as empty).
It also adds unit tests for these null cases.
Issues Resolved
This Pull Request resolved the issue #1887
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.