Fix deserialization regression when parsing failed_shards from a search result#1889
Open
janhoy wants to merge 3 commits intoopensearch-project:3.xfrom
Open
Fix deserialization regression when parsing failed_shards from a search result#1889janhoy wants to merge 3 commits intoopensearch-project:3.xfrom
janhoy wants to merge 3 commits intoopensearch-project:3.xfrom
Conversation
…ch result Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
janhoy
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
Signed-off-by: Jan Høydahl <jan.git@cominvent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a surgical back port of the intent from opensearch-project/opensearch-api-specification#1040 but intended for 3.x line of java client. It targets branch
3.xonly, and patches OpenAPI spec with only one line to rectify the regression caused when makingprimarya required field.The reason I did not attempt this over at
opensearch-api-specificationrepo is that that repo seems to not have a multi-version release scheme set up, everything is put into main branch and it is unclear what version of the spec is currently used in java-client 3.6 and how to patch only that version.Issues Resolved
Fixes #1877
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.