Introduce forced compilation deps for consistent CLI builds#5132
Introduce forced compilation deps for consistent CLI builds#5132Swiddis wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThese changes add explicit task dependencies to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
CLI build passed 3 times in a row, in another PR it was failing 2/3 times so I suspect this did the trick |
Gradle should normally infer compileJava → :dep:classes ordering from implementation/api project dependencies automatically. Is there something specific about the CLI composite build setup that breaks this? |
Description
It looks like sometimes the CLI fails to build in CI because of a compilation race condition -- this adds some explicit dependencies to hopefully fix the flakiness.
Will rerun a few times to see if CLI failures continue.
Related Issues
Flaky CI coming up in #5129 and #5080
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.