Skip to content

Potential fixes for 2 code quality findings #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matteius merged 2 commits into from
Feb 21, 2026
Merged

Potential fixes for 2 code quality findings #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe41b6
Apply suggested fix to tests/unit/test_memory.c from Copilot Autofix
matteius Feb 21, 2026
8856a4e
Apply suggested fix to tests/unit/test_memory.c from Copilot Autofix
matteius Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/unit/test_memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ void test_safe_strcpy_success(void) {

void test_safe_strcpy_truncation_returns_error(void) {
char buf[4];
memset(buf, 0, sizeof(buf));
int rc = safe_strcpy(buf, "hello_world", sizeof(buf));
TEST_ASSERT_NOT_EQUAL(0, rc);
/* buf should still be null-terminated and contain truncated data */
Expand All @@ -121,6 +122,9 @@ void test_safe_strcat_overflow_returns_error(void) {
char buf[8] = "hello";
int rc = safe_strcat(buf, "_overflow", sizeof(buf));
TEST_ASSERT_NOT_EQUAL(0, rc);
/* Buffer should remain a valid, null-terminated string and keep its safe content */
TEST_ASSERT_EQUAL_INT('\0', buf[sizeof(buf) - 1] == '\0' ? '\0' : buf[sizeof(buf) - 1]);
TEST_ASSERT_EQUAL_STRING_LEN("hello", buf, 5);
}

/* ================================================================
Expand Down
Loading