METAL-1846: Add local e2e helper; keep CI on make e2e-tests#145
Open
elfosardo wants to merge 1 commit into
Open
METAL-1846: Add local e2e helper; keep CI on make e2e-tests#145elfosardo wants to merge 1 commit into
elfosardo wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
/retest |
Introduce hack/e2e.sh for local runs: optional fast checks (kustomize, unit tests) then make e2e-tests, the same target hack/ci-e2e-test.sh runs on the Equinix test host. Add make e2e-ci, e2e, and local-e2e targets. e2e-ci aliases e2e-tests for reproducing the CI step locally. E2E_TIMEOUT and E2E_RUN are set from the Makefile. OpenShift CI is unchanged: openshift/release still runs ci-e2e-test.sh, which does not invoke hack/e2e.sh. Document CI vs local workflows in README. Assisted-By: Claude Code (commercial license)
elfosardo
changed the title
Contributor
|
Could you rename the targets and the script to include "local" in the name? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce hack/e2e.sh for local runs: optional fast checks (kustomize,
unit tests) then make e2e-tests, the same target hack/ci-e2e-test.sh
runs on the Equinix test host.
Add make e2e-ci, e2e, and local-e2e targets. e2e-ci aliases e2e-tests
for reproducing the CI step locally. E2E_TIMEOUT and E2E_RUN are set
from the Makefile.
OpenShift CI is unchanged: openshift/release still runs ci-e2e-test.sh,
which does not invoke hack/e2e.sh.
Document CI vs local workflows in README.
Assisted-By: Claude Code (commercial license)