HYPERFLEET-630 - fix: consolidate duplicate resource operation logs#84
HYPERFLEET-630 - fix: consolidate duplicate resource operation logs#84xueli181114 wants to merge 1 commit intoopenshift-hyperfleet:mainfrom
Conversation
Remove redundant pre/post operation logs from k8s_client and maestro_client CRUD methods. The executor layer provides a single authoritative INFO log per resource operation. The apply-layer decision log (operation + reason) is retained at DEBUG level. Handle "already exists" errors from concurrent creates gracefully by treating them as a successful skip instead of an ERROR.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
WalkthroughThis pull request enhances the reliability of concurrent resource creation and reduces logging verbosity. In the Kubernetes client, the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
| result.Reason = "already exists (concurrent create)" | ||
| applyErr = nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing test coverage for this change
Summary
k8s_clientandmaestro_clientCRUD methods (25 log lines removed)Test plan
make test-allpasses (lint + unit + integration tests)Relates to: HYPERFLEET-630
Summary by CodeRabbit
Bug Fixes
Chores