HYPERFLEET-786 - chore: align adapter values to Helm chart conventions

[xueli181114]

Summary

• Convert broker keys from snake_case to camelCase in helm/adapter1/2/3/values.yaml
• Update image.repository to include org path (openshift-hyperfleet/hyperfleet-adapter)
• Update scripts/tf-helm-values.sh to generate camelCase keys

Aligns with the Helm chart conventions standard defined in openshift-hyperfleet/architecture#108.

Depends on: openshift-hyperfleet/hyperfleet-adapter#85

Relates to: HYPERFLEET-786

Summary by CodeRabbit

• Chores
  • Updated Helm chart dependencies for hyperfleet-adapter and hyperfleet-sentinel to version 2.0.0 with new repository sources
  • Renamed Sentinel configuration root key throughout Helm charts
  • Updated configuration placeholder values across Helm installation files
  • Updated Google Pub/Sub field naming conventions in configuration generation
  • Updated Helm command parameters in build scripts

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

This PR refactors Helm chart configuration and dependencies across multiple Sentinel and adapter charts. The root Helm values key for Sentinel changes from sentinel: to hyperfleet-sentinel:, applied consistently across configuration values files, scripts, and Makefile targets. Pub/Sub broker field names are updated from snake_case to camelCase. All adapter charts (adapter1, adapter2, adapter3) are updated to reference version 2.0.0 of the hyperfleet-adapter dependency from a new repository source. The Sentinel cluster and nodepool charts are similarly updated to reference the renamed hyperfleet-sentinel dependency from the new source. Configuration placeholder values are standardized to CHANGE_ME.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: aligning adapter values to Helm chart conventions, which matches the primary objective of converting to camelCase keys and updating repository paths.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rafabene]

/retest

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@helm/sentinel-clusters/Chart.yaml`:
- Line 11: The Chart dependency's repository field currently points to a
personal fork and a mutable branch ref
("git+https://github.com/xueli181114/hyperfleet-sentinel@charts?ref=HYPERFLEET-786");
change it to the official hyperfleet-sentinel repository and use an immutable
ref (a release tag or commit SHA) instead of the branch name so the chart
dependency is reproducible—update the repository value and ref in the repository
string in Chart.yaml for the sentinel-clusters chart (and apply the same change
in the sentinel-nodepools Chart.yaml) to reference e.g. the upstream URL with a
tag or SHA.

In `@helm/sentinel-nodepools/Chart.yaml`:
- Line 11: Replace the dependency repository value that currently points to
"git+https://github.com/xueli181114/hyperfleet-sentinel@charts?ref=HYPERFLEET-786"
with the organization-owned repo URL
"git+https://github.com/openshift-hyperfleet/hyperfleet-sentinel@charts" and pin
the ref query to an immutable identifier (a commit SHA or a released tag)
instead of the branch name; update the repository string in the Chart.yaml
dependency entry(s) for the sentinel charts (the repository field) and ensure
all other chart dependencies use the same org repo and immutable refs so
reproducibility and supply-chain integrity are preserved.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c91d305a-016f-4e0b-89d3-d00a9bfabd9f

📥 Commits

Reviewing files that changed from the base of the PR and between b5f35ab and 3312b66.

📒 Files selected for processing (9)

• Makefile
• helm/adapter1/Chart.yaml
• helm/adapter2/Chart.yaml
• helm/adapter3/Chart.yaml
• helm/sentinel-clusters/Chart.yaml
• helm/sentinel-clusters/values.yaml
• helm/sentinel-nodepools/Chart.yaml
• helm/sentinel-nodepools/values.yaml
• scripts/tf-helm-values.sh

✅ Files skipped from review due to trivial changes (3)

• helm/adapter3/Chart.yaml
• helm/adapter1/Chart.yaml
• helm/adapter2/Chart.yaml

🚧 Files skipped from review as they are similar to previous changes (3)

• scripts/tf-helm-values.sh
• helm/sentinel-nodepools/values.yaml
• helm/sentinel-clusters/values.yaml

[xueli181114]

/retest

[xueli181114]

/retest

[xueli181114]

/retest

[xueli181114]

/retest-required

[86254860]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 86254860

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [86254860]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment