Skip to content

NO-ISSUE: Fix warning with wrap_if_ipv6 #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bfournie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NO-ISSUE: Fix warning with wrap_if_ipv6 #1905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions agent/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/usr/bin/env bash
set -euxo pipefail

source "${SCRIPTDIR}/network.sh"

export AGENT_STATIC_IP_NODE0_ONLY=${AGENT_STATIC_IP_NODE0_ONLY:-"false"}
export AGENT_NMSTATE_DHCP=${AGENT_NMSTATE_DHCP:-"false"}

Expand Down Expand Up @@ -49,10 +51,6 @@ export EXTRA_MANIFESTS_PATH="${OCP_DIR}/openshift"
# 3. ISCSI, to contain the iPXE file needed for iSCSI booting
export BOOT_SERVER_DIR=${WORKING_DIR}/boot-artifacts
export PXE_BOOT_FILE=agent.x86_64.ipxe
# FIXME: agent/common.sh is sourced without network.sh
# wrap_if_ipv6 and PROVISIONING_HOST_EXTERNAL_IP are undefined
# errors masked by export which returns true
# shellcheck disable=SC2155,SC2086
export BOOT_SERVER_URL=http://$(wrap_if_ipv6 ${PROVISIONING_HOST_EXTERNAL_IP:-}):${AGENT_BOOT_SERVER_PORT}

# Configure the instances for PXE booting
Expand Down