ROSAENG-65009: fix: passthrough codegen roundtrip rework - #323
Merged
openshift-merge-bot[bot] merged 3 commits intoAug 12, 2026
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Collaborator
|
@cdoan1: This pull request references ROSAENG-65009 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift-online/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe change narrows passthrough API schemas, adds field registry metadata, makes passthrough generation registry-driven, updates Makefile dependencies, and expands platform conversion field coverage. ChangesPassthrough code generation
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Makefile
participant codegen-registry
participant passthrough-gen
participant GeneratedPassthrough
Makefile->>codegen-registry: Generate field_metadata.json
Makefile->>passthrough-gen: Pass registry file
passthrough-gen->>GeneratedPassthrough: Parse passthrough declarations
passthrough-gen-->>Makefile: Generate passthrough output
🚥 Pre-merge checks | ✅ 9 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cdoan1
force-pushed
the
ROSAENG-65009-passthrough-codegen-roundtrip-rework
branch
from
August 12, 2026 04:12
6492ffd to
36b394f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Makefile (1)
364-372: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winInclude passthrough output in the verification workflow.
codegen-verifyonly refreshes the registry and builds packages.verify-codegenonly checks deepcopy and registry diffs. A stalezz_generated.passthrough.gocan therefore pass CI, despite the documented round-trip guarantee.
Makefile#L364-L372: make verification runcodegen-passthroughand diffapi/v1alpha1/zz_generated.passthrough.go.docs/api/passthrough-design.md#L151-L161: retain the CI verification claim only after the Makefile verifies passthrough output.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 364 - 372, The codegen verification workflow must regenerate and validate passthrough output. In Makefile lines 364-372, update codegen-verify to run codegen-passthrough and update verify-codegen to diff api/v1alpha1/zz_generated.passthrough.go alongside the existing generated files. In docs/api/passthrough-design.md lines 151-161, retain the CI verification claim after the Makefile checks passthrough output.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/v1alpha1/public/hostedclusterspecpassthrough_types.go`:
- Around line 14-40: Regenerate the public API deepcopy output for the changed
types, including Cluster, NodePool, and other public API root types, so their
generated DeepCopyObject methods implement runtime.Object and the public API
package builds successfully. Commit the regenerated output alongside the
HostedClusterSpecPassthrough API change.
In `@docs/api/passthrough-design.md`:
- Around line 96-106: Update the “Type overrides” section to describe the
implemented -type-overrides behavior, removing “planned” wording and references
to it as a remaining gap. Retain the invocation and explain that overrides are
applied during type resolution before import collection; update the
corresponding remaining-gaps entry as well.
In `@Makefile`:
- Around line 348-358: Update the codegen-passthrough-clobber target
prerequisites to include codegen-registry before deleting the generated
passthrough file and invoking passthrough-gen, ensuring the generator uses
refreshed registry metadata.
---
Outside diff comments:
In `@Makefile`:
- Around line 364-372: The codegen verification workflow must regenerate and
validate passthrough output. In Makefile lines 364-372, update codegen-verify to
run codegen-passthrough and update verify-codegen to diff
api/v1alpha1/zz_generated.passthrough.go alongside the existing generated files.
In docs/api/passthrough-design.md lines 151-161, retain the CI verification
claim after the Makefile checks passthrough output.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4a6696bd-2b6e-4489-bbc0-15c2980b62a7
⛔ Files ignored due to path filters (3)
api/v1alpha1/public/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/v1alpha1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/v1alpha1/zz_generated.passthrough.gois excluded by!**/zz_generated*
📒 Files selected for processing (17)
Makefileapi/v1alpha1/public/hostedclusterspecpassthrough_types.goapi/v1alpha1/public/nodepoolspecpassthrough_types.goapi/v1alpha1/public/openapi.yamldocs/api/passthrough-design.mdhack/api-codegen/cmd/passthrough-gen/field_metadata.jsonhack/api-codegen/cmd/passthrough-gen/main.gohack/api-codegen/pkg/conversion/generator.gohack/api-codegen/pkg/markers/scanner.gohack/api-codegen/pkg/markers/scanner_test.gohack/api-codegen/pkg/passthrough/loader.gohack/api-codegen/pkg/passthrough/loader_test.gohack/api-codegen/pkg/passthrough/types.gohack/api-codegen/pkg/registry/field_metadata.gohack/api-codegen/pkg/registry/field_metadata.jsonhyperfleet-operator/config/crd/bases/hyperfleet.io_clusters.yamlplatform-api/pkg/conversion/types.go
💤 Files with no reviewable changes (4)
- hack/api-codegen/cmd/passthrough-gen/field_metadata.json
- api/v1alpha1/public/openapi.yaml
- api/v1alpha1/public/nodepoolspecpassthrough_types.go
- hack/api-codegen/pkg/markers/scanner_test.go
cdoan1
force-pushed
the
ROSAENG-65009-passthrough-codegen-roundtrip-rework
branch
2 times, most recently
from
August 12, 2026 04:26
362f8e1 to
d750955
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/v1alpha1/public/hostedclusterspecpassthrough_types.go`:
- Around line 14-15: Regenerate and commit the complete deepcopy output for the
api/v1alpha1/public package so Cluster, NodePool, ManagementCluster, Manifest,
Placement, and their list types implement DeepCopyObject. Ensure the generated
files include all methods required for the package to compile alongside the
Release field change.
- Around line 54-55: Add the missing MaxItems=255 validation marker to
ImageContentSources in the passthrough schema, matching
HostedClusterSpec.ImageContentSources, then regenerate the OpenAPI and CRD
schemas.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5c15ba3c-6bd6-462f-8f14-dabbd547b37b
⛔ Files ignored due to path filters (1)
api/v1alpha1/public/zz_generated.deepcopy.gois excluded by!**/zz_generated*
📒 Files selected for processing (3)
api/v1alpha1/public/hostedclusterspecpassthrough_types.goapi/v1alpha1/public/nodepoolspecpassthrough_types.goplatform-api/pkg/conversion/types.go
🚧 Files skipped from review as they are similar to previous changes (1)
- platform-api/pkg/conversion/types.go
Collaborator
Author
|
/retest |
cdoan1
force-pushed
the
ROSAENG-65009-passthrough-codegen-roundtrip-rework
branch
2 times, most recently
from
August 12, 2026 13:18
8579232 to
518af2f
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/api-codegen/cmd/passthrough-gen/main.go`:
- Around line 29-35: Update the passthrough generation flow around flag
validation and registry loading so codegen-passthrough-clobber invokes or
otherwise depends on codegen-registry before reading field_metadata.json,
ensuring marker metadata is regenerated rather than stale and handling the
absent-file case successfully. Use the existing codegen-registry target or
function instead of duplicating registry generation logic.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8390526d-221f-4ebe-b135-a653eba1ac0f
⛔ Files ignored due to path filters (2)
api/v1alpha1/public/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/v1alpha1/zz_generated.passthrough.gois excluded by!**/zz_generated*
📒 Files selected for processing (8)
Makefileapi/v1alpha1/public/hostedclusterspecpassthrough_types.gohack/api-codegen/cmd/passthrough-gen/main.gohack/api-codegen/pkg/passthrough/loader.gohack/api-codegen/pkg/registry/field_metadata.gohack/api-codegen/pkg/registry/field_metadata.jsonplatform-api/go.modplatform-api/pkg/conversion/types.go
💤 Files with no reviewable changes (1)
- hack/api-codegen/pkg/passthrough/loader.go
🚧 Files skipped from review as they are similar to previous changes (4)
- hack/api-codegen/pkg/registry/field_metadata.go
- hack/api-codegen/pkg/registry/field_metadata.json
- api/v1alpha1/public/hostedclusterspecpassthrough_types.go
- platform-api/pkg/conversion/types.go
Documents the passthrough round-trip pipeline, curation workflow, marker types, safe defaults, and five remaining gaps to fix on main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove stale embedded registry from passthrough-gen, make -registry mandatory - Fix scanner and conversion-gen file filters to read zz_generated.passthrough.go - Add -type-overrides flag to passthrough-gen for local type substitution - Extract parseStructType() to reduce cyclomatic complexity in conversion-gen - Fix Makefile dependency chain: codegen-passthrough depends on codegen-registry - Regenerate downstream outputs (registry, deepcopy, REST types, OpenAPI, CRDs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type override feature removed — already implemented separately in main. Update design doc to reflect resolved gaps and remove stale references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cdoan1
force-pushed
the
ROSAENG-65009-passthrough-codegen-roundtrip-rework
branch
from
August 12, 2026 14:30
635990f to
9eaa448
Compare
Collaborator
Author
|
/retest |
Collaborator
Author
|
/honk |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoan1, gdbranco The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Aug 12, 2026
f0366b5
into
openshift-online:main
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
The passthrough codegen pipeline had several gaps preventing a clean round-trip (make codegen-registry && make codegen-passthrough && git diff --exit-code):
Changes
Verification
Type of Change
Testing
make test)Checklist
Summary by CodeRabbit
API Changes
Etcdsetting.Documentation