[fournos] Update to the lastest fournos version by kpouget · Pull Request #51 · openshift-psap/forge

kpouget · 2026-05-04T12:16:49Z

Summary by CodeRabbit

Refactor
- Updated execution engine configuration structure, replacing previous field references with standardized naming conventions for improved consistency and clarity in job specifications.

openshift-ci · 2026-05-04T12:16:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign albertoperdomo2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-05-04T12:16:59Z

Warning

Rate limit exceeded

@kpouget has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 3 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a815c33-e6d1-4cdc-9f9e-aa7837ee691a

📥 Commits

Reviewing files that changed from the base of the PR and between 9bf10c8 and af46647.

📒 Files selected for processing (2)

projects/core/ci_entrypoint/fournos.py
projects/fournos_launcher/toolbox/submit_and_wait/templates/job.yaml.j2

📝 Walkthrough

Walkthrough

The PR refactors the Fournos job execution-engine configuration structure, replacing the spec.forge key with spec.executionEngine and spec.executionEngineSpec. A new constant validates the engine name, and the configuration processing logic is updated to read project/args/config overrides from the new location.

Changes

Execution Engine Configuration Refactoring

Layer / File(s)	Summary
Constant Definition `projects/core/ci_entrypoint/fournos.py`	Introduced `FJOB_FORGE_ENGINE_NAME = "forge"` to standardize the engine identifier.
Data Structure `projects/fournos_launcher/toolbox/submit_and_wait/templates/job.yaml.j2`	Job template now emits `executionEngine: forge` and `executionEngineSpec:` block instead of the prior `forge:` key.
Validation & Processing `projects/core/ci_entrypoint/fournos.py`	`transform_fournos_config_to_variable_overrides()` validates `fjob.spec.executionEngine` against the constant and reads project/args/config overrides from `spec.executionEngineSpec` instead of `spec.forge`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

[fournos-launcher] Submit jobs to the psap-mgmt cluster #19: Modifies Fournos job template execution-engine fields and related spec.forge parsing; directly related to the schema and structure changes in this PR.

Poem

A rabbit hops through forge's gate,
Where executionEngine seals the fate,
From spec.forge we migrate our way,
To executionEngineSpec—hooray!
One constant name, one clearer day. 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title mentions updating to 'the latest fournos version' but lacks specificity about the actual changes (introduction of executionEngine/executionEngineSpec and migration from forge config).	Consider a more specific title like '[fournos] Migrate to executionEngine/executionEngineSpec configuration' to clearly convey the primary structural change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 0/1 reviews remaining, refill in 1 minute and 3 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

kpouget · 2026-05-04T15:39:18Z

/test fournos skeleton
/var fournos.namespace: psap-automation-wip
/parallel 1 quick_test
/parallel 2 medium_test
/parallel 3 quick_test side_testing
/cluster psap-mgmt

psap-forge-bot · 2026-05-04T15:41:11Z

🔴 Test of 'fournos_launcher submit' failed after 00 hours 00 minutes 11 seconds 🔴

• Link to the test results.

• No reports index generated...

Test configuration:

/test fournos skeleton
/var fournos.namespace: psap-automation-wip
/parallel 1 quick_test
/parallel 2 medium_test
/parallel 3 quick_test side_testing
/cluster psap-mgmt

• Failure indicator: Empty.
• Execution logs

kpouget · 2026-05-04T15:49:58Z

/test fournos skeleton
/var fournos.namespace: psap-automation-wip
/parallel 1 quick_test
/parallel 2 medium_test
/parallel 3 quick_test side_testing
/cluster psap-mgmt

psap-forge-bot · 2026-05-04T15:57:16Z

🔴 Test of 'fournos_launcher submit' failed after 00 hours 05 minutes 22 seconds 🔴

• Link to the test results.

• No reports index generated...

Test configuration:

/test fournos skeleton
/var fournos.namespace: psap-automation-wip
/parallel 1 quick_test
/parallel 2 medium_test
/parallel 3 quick_test side_testing
/cluster psap-mgmt

• Failure indicator: Empty.
• Execution logs

kpouget · 2026-05-04T16:08:08Z

/test fournos skeleton
/var fournos.namespace: psap-automation-wip
/parallel 1 quick_test
/parallel 2 medium_test
/parallel 3 quick_test side_testing
/cluster psap-mgmt

psap-forge-bot · 2026-05-04T16:08:15Z

🟢 Test of 'skeleton test' succeeded after 00 hours 00 minutes 10 seconds 🟢

• Link to the test results.

• No reports index generated...

Test configuration:

ci_job.cluster: psap-mgmt
ci_job.exclusive: true
ci_job.fjob: forge-skeleton-20260504-155154-3
ci_job.hardware:
  gpuCount: 4
  gpuType: h200
ci_job.name: skeleton quick_test side_testing (job 3)
ci_job.owner: kpouget
project.args:
- quick_test
- side_testing
project.name: skeleton

• Execution logs

psap-forge-bot · 2026-05-04T16:10:15Z

🟢 Test of 'skeleton test' succeeded after 00 hours 00 minutes 11 seconds 🟢

• Link to the test results.

• No reports index generated...

Test configuration:

ci_job.cluster: psap-mgmt
ci_job.exclusive: true
ci_job.fjob: forge-skeleton-20260504-160834-3
ci_job.hardware:
  gpuCount: 4
  gpuType: h200
ci_job.name: skeleton quick_test side_testing (job 3)
ci_job.owner: kpouget
project.args:
- quick_test
- side_testing
project.name: skeleton

• Execution logs

psap-forge-bot · 2026-05-04T16:13:10Z

🟢 Test of 'skeleton test' succeeded after 00 hours 02 minutes 00 seconds 🟢

• Link to the test results.

• No reports index generated...

Test configuration:

ci_job.cluster: psap-mgmt
ci_job.exclusive: true
ci_job.fjob: forge-skeleton-20260504-160834-2
ci_job.hardware:
  gpuCount: 4
  gpuType: h200
ci_job.name: skeleton medium_test (job 2)
ci_job.owner: kpouget
project.args:
- medium_test
project.name: skeleton

• Execution logs

psap-forge-bot · 2026-05-04T16:14:15Z

🟢 Test of 'skeleton test' succeeded after 00 hours 00 minutes 10 seconds 🟢

• Link to the test results.

• No reports index generated...

Test configuration:

ci_job.cluster: psap-mgmt
ci_job.exclusive: true
ci_job.fjob: forge-skeleton-20260504-160834-1
ci_job.hardware:
  gpuCount: 4
  gpuType: h200
ci_job.name: skeleton quick_test (job 1)
ci_job.owner: kpouget
project.args:
- quick_test
project.name: skeleton

• Execution logs

psap-forge-bot · 2026-05-04T16:14:54Z

🟢 Test of 'fournos_launcher submit' succeeded after 00 hours 06 minutes 21 seconds 🟢

• Link to the test results.

• No reports index generated...

Test configuration:

/test fournos skeleton
/var fournos.namespace: psap-automation-wip
/parallel 1 quick_test
/parallel 2 medium_test
/parallel 3 quick_test side_testing
/cluster psap-mgmt

• Execution logs

kpouget force-pushed the engine branch from 9bf10c8 to bcd4f5b Compare May 4, 2026 15:48

kpouget added 2 commits May 4, 2026 17:49

[core] ci_entrypoint: fournos: update the FJob parser

4df458d

[fournos_launcher] toolbox: submit_and_wait: update to fjob definition

af46647

kpouget force-pushed the engine branch from bcd4f5b to af46647 Compare May 4, 2026 15:49

kpouget mentioned this pull request May 4, 2026

Introduce executionEngine in CRD openshift-psap/fournos#77

Merged

kpouget merged commit 9cd7af7 into openshift-psap:main May 4, 2026
6 of 7 checks passed

kpouget deleted the engine branch May 4, 2026 19:25

coderabbitai Bot mentioned this pull request May 6, 2026

[caliper] Start integrating the post-processing in the orchestration layer #55

Merged

Conversation

kpouget commented May 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented May 4, 2026

Uh oh!

coderabbitai Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

kpouget commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

kpouget commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

kpouget commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

psap-forge-bot Bot commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kpouget commented May 4, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 4, 2026 •

edited

Loading