Skip to content

Adjust tags in image-push GHA#80

Open
avasilevskii wants to merge 1 commit intoopenshift-psap:mainfrom
avasilevskii:adjust-gha-image-push
Open

Adjust tags in image-push GHA#80
avasilevskii wants to merge 1 commit intoopenshift-psap:mainfrom
avasilevskii:adjust-gha-image-push

Conversation

@avasilevskii
Copy link
Copy Markdown
Collaborator

Preparation step for #8.
Change of image push behavior and tags:

  • Build images on main branch merges and push them with latests tag.
  • Build images on GH release and push them with stable and release tag.

Signed-off-by: avasilev <avasilev@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mml-coder for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@avasilevskii has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 4 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 917c25fd-44be-4abd-84dd-3237b7b74507

📥 Commits

Reviewing files that changed from the base of the PR and between 664bf78 and ce503f7.

📒 Files selected for processing (1)
  • .github/workflows/image-push.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- name: Determine tags
id: tags
run: |
TAGS="${{ github.sha }}"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a short sha? (7-8 first chars)

@kpouget
Copy link
Copy Markdown
Collaborator

kpouget commented May 6, 2026

lgtm, just a minor comment related to the tag name size
(I'm not sure if ${{ github.sha }} is the full SHA, 41 chars. If yes we can truncate it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants