Refactor update.sh script#31
Draft
MaxBab wants to merge 1 commit into
Draft
Conversation
MaxBab
force-pushed
the
refactor_update_flow_execution
branch
2 times, most recently
from
0612c87 to
e886ec2
Compare
- Fix update.sh flow execution Due to the recent changes
in github api, cherry-picked commit do not return anymore
the PR they're associated to.
As a result, the following changes needs to be done
to keep the working logic.
- Add two execution modes.
- default - Process only new commits.
- force - Controlled by "FORCE_LABEL_UPDATE=true" env var.
Process all commits. This change would dramatically
dicrease the amount of api calls per job execution.
- Added a separate PR filed and a representation of that
filed in istio.md file.
- In additional to the existing logic of fetching PRs
associated with the commit, added a logic that in case
the previous logic fails, it fetches last 50 PRs of the
repo and checks if the commit exists within the PR.
Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
MaxBab
force-pushed
the
refactor_update_flow_execution
branch
from
e886ec2 to
59cc09d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix update.sh flow execution Due to the recent changes in github api, cherry-picked commit do not return anymore the PR they're associated to. As a result, the following changes needs to be done to keep the working logic.
Add two execution modes.
Added a separate PR filed and a representation of that filed in istio.md file.
In additional to the existing logic of fetching PRs associated with the commit, added a logic that in case the previous logic fails, it fetches last 50 PRs of the repo and checks if the commit exists within the PR.